Skip to content

Commit

Permalink
Use latest plugin version in deployment examples
Browse files Browse the repository at this point in the history
Using a specific version of the plugin in
deployment examples requires updating it
for each release. This poses a risk of users
deploying an older version of the plugin than the
specific one they checked out.

The proposal is to always use `latest` and then in
every release, update yaml for the release and
upload it to the release page.
  • Loading branch information
almaslennikov committed Mar 29, 2022
1 parent 43b76df commit 39df130
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deployments/k8s-v1.10-v1.15/sriovdp-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
serviceAccountName: sriov-device-plugin
containers:
- name: kube-sriovdp
image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin:v3.3.2
image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin:latest
imagePullPolicy: IfNotPresent
args:
- --log-dir=sriovdp
Expand Down
2 changes: 1 addition & 1 deletion deployments/k8s-v1.16/sriovdp-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
serviceAccountName: sriov-device-plugin
containers:
- name: kube-sriovdp
image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin:v3.3.2
image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin:latest
imagePullPolicy: IfNotPresent
args:
- --log-dir=sriovdp
Expand Down

0 comments on commit 39df130

Please sign in to comment.