add missing linkTypes selector and fix nits

Change-Id: Ia7fd5b45fbee3058c88eb19f1b2d2fbfb634e162
k8snetworkplumbingwg · Feb 6, 2020 · d8baede · d8baede
1 parent d4d58d2
commit d8baede
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/cmd/sriovdp/manager.go b/cmd/sriovdp/manager.go
@@ -318,6 +318,16 @@ func (rm *resourceManager) getFilteredDevices(rc *types.ResourceConfig) []types.
 		}
 	}
 
+	// filter by linkTypes list
+	if rc.Selectors.LinkTypes != nil && len(rc.Selectors.LinkTypes) > 0 {
+		if len(rc.Selectors.LinkTypes) > 1 {
+			glog.Warningf("Link type selector should have a single value.")
+		}
+		if selector, err := rf.GetSelector("linkTypes", rc.Selectors.LinkTypes); err == nil {
+			filteredDevice = selector.Filter(filteredDevice)
+		}
+	}
+
 	// filter by DDP Profiles list
 	if rc.Selectors.DDPProfiles != nil && len(rc.Selectors.DDPProfiles) > 0 {
 		if selector, err := rf.GetSelector("ddpProfiles", rc.Selectors.DDPProfiles); err == nil {

diff --git a/docs/ddp/README.md b/docs/ddp/README.md
@@ -5,9 +5,9 @@ Dynamic Device Personalization aka DDP allows dynamic reconfiguration of the pac
 
 (ref: [Dynamic Device Personalization for Intel® Ethernet 700 Series](https://software.intel.com/en-us/articles/dynamic-device-personalization-for-intel-ethernet-700-series))
 
-The SR-IOV network device plugin could be used to identify currently running DDP *profiles*, thus allow it to filter Virtual Functions by their DDP profile names.
+The SR-IOV network device plugin can be used to identify currently running DDP *profiles*, allowing it to filter Virtual Functions by their DDP profile names.
 
-The Intel Ethernet 700 Series, a DDP profiles can be loaded/unloaded into the NIC using i40e kernel module(v2.7.26+) and ethtool OR using DPDK i40e pollmode driver & DPDK api. In this documentation we will cover i40e Kernel driver mode.
+The Intel Ethernet 700 Series, a DDP profile can be loaded/unloaded into the NIC using i40e kernel module(v2.7.26+) and ethtool OR using DPDK i40e pollmode driver & DPDK api. In this documentation we will cover i40e Kernel driver mode.
 
 ## Pre-requisites
  * Firmware: v6.01 or newer
@@ -62,7 +62,7 @@ $ echo 2 > /sys/class/net/enp2s0f0/device/sriov_numvfs
 ```
 
 ## 4. Verify that correct profile is loaded
-You can use another Linux utility for Intel 700 Series called `ddptool` to query current DDP profile information. This tool can downloaded from [here]( https://downloads.sourceforge.net/project/e1000/ddptool%20stable/ddptool-1.0.0.0/ddptool-1.0.0.0.tar.gz).
+You can use another Linux utility for Intel 700 Series called `ddptool` to query current DDP profile information. This tool can be downloaded from [here]( https://downloads.sourceforge.net/project/e1000/ddptool%20stable/ddptool-1.0.0.0/ddptool-1.0.0.0.tar.gz).
 
 ```
 [root@silpixa00396659 ~]# ddptool -a