-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to go mod #225
Switch to go mod #225
Conversation
Hi @SchSeba thanks for this PR.,
|
dc1616e
to
d397e65
Compare
Hi @ahalim-intel thanks for the comment here is my replay.
I remove the glide files but keep the vendor folder.
This will continue to support the same versions as before because we are still using the |
@ahalim-intel can you please take another look on this PR? |
/lgtm |
Makefile
Outdated
@ln -nsf . vendor/src | ||
@touch $@ | ||
.PHONY: deps-update | ||
deps-update: $(info updating dependencies...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma after deps-update:
. It makes updating dependencies
info always be printed when make
is executed even if it's not updating dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for the comment!
I fix it :)
This commmit also update the kubernetes version. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
/lgtm |
@SchSeba when generating go.mod, did you manually remove those indirect dependencies or it is not generated at all? In my local run, there are three indrect dependencies and I was using go1.12.17 with GO111MODULE set to auto. |
@zshi-redhat I did not remove anything from the go.mod file manually. I am using 1.13 with GO111MODULE set to on |
This commmit also update the kubernetes version.
Signed-off-by: Sebastian Sch sebassch@gmail.com