fix pfNames selector to skip device with no PF name #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Current behaviour of pfName selector adds devices that do not have PF names available. For instance, if there is a PF attached to igb_uio driver and VFs are created under that PF, those VFs will have no PF name information. If a resource config prvides the "pfName" selector any VFs under that PF(igb_uio driver) will wrongly be added to that pool. This happens because this selector matches PF name with string.HasPrefix() method and providing "" for PF name results in true. Fix: skip devices that do not have PF names when "pfNames" selector is used. Change-Id: I1ddd49743ef2e8f25718285e80c16dfcef4c90f5 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
force-pushed
the
dev/fix_pfNames_selector
branch
from
a6ba00e
to
4a02c30
Compare
|
fixed typos in commit message |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour of pfName selector adds devices that do not have
PF names available. For instance, if there is a PF attached to
igb_uio driver and VFs are created under that PF, those VFs will
have no PF name information. If a resource config prvides the
"pfName" selector any VFs under that PF(igb_uio driver) will
wrongly be added to that pool. This happens because this selector
matches PF name with string.HasPrefix() method and providing ""
for PF name results in true.
Fix: skip devices that do not have PF names when "pfNames" selector
is used.
Change-Id: I1ddd49743ef2e8f25718285e80c16dfcef4c90f5
Signed-off-by: Abdul Halim abdul.halim@intel.com