added VF set up guide to docs #240
Conversation
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
7 times, most recently
from
bac7a5b
to
9255340
Compare
|
LGTM |
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
3 times, most recently
from
87ac55f
to
066304b
Compare
| * Intel® Ethernet Controller X520 | ||
| * Intel® Ethernet Controller X540 | ||
| * Intel® Ethernet Controller x550 | ||
| * Intel® Ethernet Controller X552 |
There was a problem hiding this comment.
I have seen one issue when provisioning VFs with intel x552 ixgbe card, that it requires two steps:
- modprobe -r ixgbe; modprobe ixgbe max_vfs=3
- echo 3 > /sys/class/net/${PF_NAME}/device/sriov_numvfs
Without step 1), step 2) fails with write error: Cannot allocate memory. Is this expected behavior?
There was a problem hiding this comment.
The driver doc says
NOTE: This parameter is only used on kernel 3.7.x and below. On kernel 3.8.x
and above, use sysfs to enable VFs. Also, for Red Hat distributions, this
parameter is only used on version 6.6 and older. For version 6.7 and newer, use
sysfs.
Are you on an older system like that? I think we should be able to figure out the cutoff version for this behaviour.
There was a problem hiding this comment.
@killianmuldoon we were using centos 7/8, it has newer kernel versions than 6.7.
@yrobla ^^
There was a problem hiding this comment.
The cannot allocate memory problem was actually a missing setting on my bios. However, i am experimenting errors on my x552 card. As soon as i do something like "echo 3 > /sys/class/net/eno3/device/sriov_numvfs" , the system reboots and seems unable to persistently keep this value.
There was a problem hiding this comment.
note: this doesn't necessary block the merging of this PR, it is just to check if we have ever hit the same issue.
There was a problem hiding this comment.
@zshi-redhat I've not had a change to figure out the issue here or where the cutoff might be for the cards/OS. I've put in a troubleshooting block with your instructions and specifically called out the error message and the 552 NIC - hopefully that should help people who run into this issue.
|
/retest |
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
from
066304b
to
60ac419
Compare
docs/vf-setup.md
Outdated
| Next set the VFs as above | ||
|
|
||
| ``` | ||
| echo 8 >> /sys/class/net/${PF_NAME}/device/sriov_numvfs |
There was a problem hiding this comment.
I think this is a type here? This should be > instead of >>
There was a problem hiding this comment.
Thanks for catching that - fixed
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
2 times, most recently
from
d87715f
to
1d200cd
Compare
docs/vf-setup.md
Outdated
| * [Mellanox](#mellanox) | ||
|
|
||
| ## Intel | ||
| The below works on intel SR-IOV enabled cards including those from the Gigabit Ethernet, X710 and X722 families of Network Interface Cards. Note not all Gigabit Ethernet NICs are enabled with SR-IOV. |
There was a problem hiding this comment.
The below works on intel SR-IOV enabled ..
Could you reword this
intel
Intel*
|
|
||
| To create 8 virtual functions run: | ||
| ``` | ||
| echo 8 > /sys/class/net/${PF_NAME}/device/sriov_numvfs |
There was a problem hiding this comment.
Should we reset the number of VFs here before asking for 8 in case it was configured previously and will throw an error if its not reset first before asking for a new set of VFs?
There was a problem hiding this comment.
Added a section under "common problems" to pick up this error if someone wants to reset the number of VFs
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
from
1d200cd
to
8202c7c
Compare
killianmuldoon
force-pushed
the
dev/vf-setup-doc
branch
3 times, most recently
from
4659f05
to
44f82b9
Compare
killianmuldoon
changed the title
Added updated version of VF creation guide from SR-IOV CNI docs to the device plugin docs folder as per k8snetworkplumbingwg/sriov-cni#74
Input welcome to update the info on VF creation here.
Once this is merged it can be linked from the new SR-IOV CNI docs contained in k8snetworkplumbingwg/sriov-cni#127