Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2020-14040 #254

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

zshi-redhat
Copy link
Collaborator

golang/x/text UTF-16 decoder behaves incorrectly on single-byte input

golang/x/text UTF-16 decoder behaves incorrectly on single-byte input
@zshi-redhat
Copy link
Collaborator Author

/cc @ahalim-intel @martinkennelly @moshe010 @adrianchiris

@adrianchiris
Copy link
Contributor

adrianchiris commented Jul 14, 2020

@Mmduh-483

@zshi-redhat have you checked which package/s depend on it and where it interfaces with our project ?
Im all for fixing CVEs so im LGTM :)

@zshi-redhat
Copy link
Collaborator Author

zshi-redhat commented Jul 14, 2020

@Mmduh-483

@zshi-redhat have you checked which package/s depend on it and where it interfaces with our project ?
Im all for fixing CVEs so im LGTM :)

I didn't check which exact function is called directly by device plugin that will cause issue.
There was a RHBZ that tracks this security issue(which is not intended to be public), the fix is in golang/x/text/unicode v0.3.3 version. some more info can be found: https://groups.google.com/g/golang-announce/c/bXVeAmGOqz0?pli=1

I updated the golang/x/text pkg with the fillowing steps:

  1. go get golang.org/x/test
  2. go mod tidy
  3. go mod vendor

@ahalimx86 ahalimx86 merged commit 938646e into k8snetworkplumbingwg:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants