Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfName selector: match exact pf name #263

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

zshi-redhat
Copy link
Collaborator

No description provided.

pfNames may contain names with overlapped prefix such as ens3f0, ens3;
this results in VFs from ens3 be wrongly exposed as extended resource
when pfNames only contain ens3f0.
@zshi-redhat
Copy link
Collaborator Author

/cc @ahalim-intel @martinkennelly @adrianchiris

@zshi-redhat
Copy link
Collaborator Author

zshi-redhat commented Aug 19, 2020

PF interface names may have overlapped prefix such as ens3f0, ens3;
this results in VFs from ens3 be wrongly exposed as extended resource
when pfNames only contain ens3f0.

@martinkennelly
Copy link
Member

/LGTM

Copy link
Collaborator

@ahalimx86 ahalimx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zshi-redhat for catching this issue and providing a fix

@ahalimx86 ahalimx86 merged commit 3c5d157 into k8snetworkplumbingwg:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants