Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment docker image version to v3.3 #308

Merged

Conversation

martinkennelly
Copy link
Member

Before I can create a new release which would increment the tag ref, I would like to update the daemonset images versions. I understand this would be invalid until a new release would be created but I would rather this than creating a release which referenced old docker image version.

Opinions?

Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
@zshi-redhat
Copy link
Collaborator

Before I can create a new release which would increment the tag ref, I would like to update the daemonset images versions. I understand this would be invalid until a new release would be created but I would rather this than creating a release which referenced old docker image version.

Opinions?

+1 on updating the tag info before creating the release.
This would allow use of new release by simply downloading the tarball or clone the new tag without having to update the daemonset.yaml or cherry-pick another tag changing commit.

@zshi-redhat zshi-redhat merged commit 726308c into k8snetworkplumbingwg:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants