Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpine 3.13 APK proxy build issue #318

Merged

Conversation

martinkennelly
Copy link
Member

@martinkennelly martinkennelly commented Jan 25, 2021

Alpine 3.13 set APK repositories to https instead of http.
APK does not work with https proxy because of libfetch issue.
Set alpine to 3.12 until issue is resolved.

Signed-off-by: Kennelly, Martin martin.kennelly@intel.com

See:
alpinelinux/docker-alpine#136
alpinelinux/docker-alpine#98
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

Partially fixes #315

Alpine 3.13 set APK repositories to https instead of http.
APK does not work with https proxy because of libfetch issue.
Set alpine to 3.12 until issue is resolved.

Signed-off-by: Kennelly, Martin <martin.kennelly@intel.com>
Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also aligns build image with final image.

once the issue is resolved we can update both hopefully

@martinkennelly
Copy link
Member Author

This also aligns build image with final image.

once the issue is resolved we can update both hopefully

Yes, it was a mistake not setting the images to a specific version. We should only upgrade once images are tested.
I think a patch version increment is needed once this is merged - so v3.3.1. WDYT?

@adrianchiris
Copy link
Contributor

adrianchiris commented Jan 27, 2021

essentially building from tag v3.3 is broken right ? yes i think its a good idea,

@martinkennelly
Copy link
Member Author

essentially building from tag v3.3 is broken right ? yes i think its a good idea,

yes - within proxy environments. Alpines APK repos were changed from http to https. This is a good thing but there is a bug in libfetch with respecting proxy settings it seems which APK depends on. So upgrading libfetch is a must and they are working on it.

@martinkennelly martinkennelly merged commit 4cbfd8c into k8snetworkplumbingwg:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile needs fixing
2 participants