Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DDPTool build with gcc 10 #333

Merged

Conversation

martinkennelly
Copy link
Member

Add upgraded DDPTool source code [1] with fix for compiling
with GCC 10. This issue was due to GCC 10 linker not
tolerating redeclartion of global variable.

[1] https://github.com/intel/ddp-tool

Signed-off-by: Kennelly, Martin martin.kennelly@intel.com

Add upgraded DDPTool source code [1] with fix for compiling
with GCC 10. This issue was due to GCC 10 linker not
tolerating redeclartion of global variable.

[1] https://github.com/intel/ddp-tool

Signed-off-by: Kennelly, Martin <martin.kennelly@intel.com>
@zshi-redhat
Copy link
Collaborator

@martinkennelly out of curious, do you know there is any work related to using devlink to query DDP info?

@martinkennelly
Copy link
Member Author

martinkennelly commented Mar 22, 2021

@zshi-redhat For E800 series there is support for devlink to read the DDP state of NICs. So for E800 series, you do not need DDPTool at all. We do need it for X700 series however for loading package and viewing DDP state.

Name Type Example Description
fw.app.name running ICE OS Default Package The name of the DDP package that is active in the device. The DDP package is loaded by the driver during initialization. Each variation of the DDP package has a unique name.
fw.app running 1.3.1.0 The version of the DDP package that is active in the device. Note that both the name (as reported by fw.app.name) and version are required to uniquely identify the package.
fw.app.bundle_id running 0xc0000001 Unique identifier for the DDP package loaded in the device. Also referred to as the DDP Track ID. Can be used to uniquely identify the specific DDP package.

ref

I want to switch to devlink for E800 series.

@zshi-redhat
Copy link
Collaborator

@martinkennelly thanks for the explanation and reference link!

@martinkennelly martinkennelly merged commit a946600 into k8snetworkplumbingwg:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants