Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Travis #359

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Removing Travis #359

merged 1 commit into from
Jul 26, 2021

Conversation

Eoghan1232
Copy link
Collaborator

Switching to ghcr as our image repository and depreciating travis following the closure of travis-ci.org.

@Eoghan1232 Eoghan1232 changed the title Removing Travis and updating images Removing Travis Jul 8, 2021
@Eoghan1232
Copy link
Collaborator Author

@zshi-redhat

@zshi-redhat
Copy link
Collaborator

@Eoghan1232 This PR seems overlapping with part of #348 ?

@Eoghan1232
Copy link
Collaborator Author

Eoghan1232 commented Jul 9, 2021 •
edited
Loading

@Eoghan1232 This PR seems overlapping with part of #348 ?

Never spotted that. I can see there is overlap between the two. In #348 the travis.yaml is not removed. There is also slight differences, I choose 3.3.2 but #348 using the latest tag. Not sure what to do.

What would be best? @zshi-redhat

@zshi-redhat
Copy link
Collaborator

@Eoghan1232 This PR seems overlapping with part of #348 ?

Never spotted that. I can see there is overlap between the two. In #348 the travis.yaml is not removed. Otherwise it seems it contains all the changes I had in my PR here.

What would be best to do? @zshi-redhat

I think we can leave this one to remove .travis.yaml and merge after #348 is done. wdyt?

@Eoghan1232
Copy link
Collaborator Author

Eoghan1232 commented Jul 9, 2021 •
edited
Loading

@Eoghan1232 This PR seems overlapping with part of #348 ?

Never spotted that. I can see there is overlap between the two. In #348 the travis.yaml is not removed. Otherwise it seems it contains all the changes I had in my PR here.
What would be best to do? @zshi-redhat

I think we can leave this one to remove .travis.yaml and merge after #348 is done. wdyt?

Yes, I think that would probably be best.

@adrianchiris
Copy link
Contributor

@Eoghan1232 mind rebasing this PR ? i have merged #348. we can now move forward with removing travis.yml.

@Eoghan1232 Eoghan1232 force-pushed the remove_travis branch 2 times, most recently from 7874588 to 18b465f Compare July 26, 2021 09:55
adrianchiris
adrianchiris approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you get the chance, please update commit msg to explain why this file is removed (project switched to github actions and this file is no longer needed)

Removing .travis.yml file
15692d8 
depreciating travis following the closure of travis-ci.org
project switched to github actions and this file is no longer needed
@Eoghan1232
Copy link
Collaborator Author

LGTM.

If you get the chance, please update commit msg to explain why this file is removed (project switched to github actions and this file is no longer needed)

Done.

@Eoghan1232
Copy link
Collaborator Author

LGTM.
If you get the chance, please update commit msg to explain why this file is removed (project switched to github actions and this file is no longer needed)

Done.

@adrianchiris @zshi-redhat
Good to merge?
I can't approve my own MR.

@Eoghan1232 Eoghan1232 merged commit 71834e6 into k8snetworkplumbingwg:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshi-redhat zshi-redhat zshi-redhat approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eoghan1232 @zshi-redhat @adrianchiris