Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DDP Docs #365

Merged

Conversation

Eoghan1232
Copy link
Collaborator

@Eoghan1232 Eoghan1232 commented Jul 26, 2021

version 1.0.0.0 of DDP tool doesn't support E810 Series NICs
Updating Docs to make note of this.

@zshi-redhat

@Eoghan1232
Copy link
Collaborator Author

Eoghan1232 commented Jul 26, 2021

Bit of background on this, Tried to use DDP profiles whilst using an older image, which had ddptool version 1.0.0.0. It did not working when using a E810 Series NIC.

The image update in this PR fixed the issue.
#348

Does the doc need to be updated to make note of this?

@@ -29,6 +29,9 @@ For Intel® Ethernet Controller X710, a DDP package can be loaded into the NIC u
## Short step by step configuration for E810 & X710 series NICs
### Install DDP packages
#### Intel® Ethernet Controller E810
ddptool : Version 1.0.0.0 Doesn't support DDP on E810 series NICs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it would be better to specify the min version of this software that will work for E810 instead of naming DDPTool which is an internal component and from a user perspective is transparent.

Copy link
Collaborator Author

@Eoghan1232 Eoghan1232 Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the min version of SRIOV DP?
Also, it was the ddptool that was the issue, and why it didn't work. so specifying the version of DP I think is irrelevant.
Since, once you use the correct version of ddptool, it worked.
Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, min version of SRIOV DP. The latest tagged release 3.3.2 should be the min version which support E800 series DDP.

Also, it was the ddptool that was the issue, and why it didn't work. so specifying the version of DP I think is irrelevant.

DDPTool is included in SRIOV DP (see images folder). From a user perspective, they don't care about version of DDPTool version. We do not want users to mix and match this tool but take the DDPTool version which comes with this software, so from their perspective, they only care about what ver of DP works with E800 series.

Copy link
Collaborator Author

@Eoghan1232 Eoghan1232 Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I understand now, that makes sense.
I will make the change, the min version I'll put down is 3.3.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Minimum version of SRIOV Network Device Plugin is 3.3.2.
DDP tool minimum version is 1.0.1.12
@adrianchiris
Copy link
Contributor

Mellanox CI issues not related to this PR. moving forward with merge

@adrianchiris adrianchiris merged commit 78f3df8 into k8snetworkplumbingwg:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants