-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive pooling #384
Exclusive pooling #384
Conversation
7a4d486
to
349a48c
Compare
LGTM 👍 |
Thanks @Eoghan1232 for working on the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrianchiris Could you please take a look?
Thanks for the PR ! It would be great if commit message contained a bit more info on the problem and how this PR solves it |
349a48c
to
45dddcd
Compare
@adrianchiris @zshi-redhat Updated implementation with Adrian's feedback. |
nit: Could you please rebase and squash the commits into one? |
8bd470f
to
99d4b66
Compare
Done. |
@zshi-redhat @adrianchiris if you are okay also, I will proceed with the merge :) |
/lgtm |
one minor nit: could you update commit msg with abit more info on this change other than that LGTM |
99d4b66
to
e1434eb
Compare
Enabling validation that a VF is only used in one resource pool This will also bring tighter config maps to ensure VF are allocated correctly
e1434eb
to
7480390
Compare
Approved by @zshi-redhat, @adrianchiris and myself. |
This PR is in relation to this:
#355
Enabling validation that a VF is only used in one resource pool.
signed off: eoghan.russell@intel.com