Exclusive pooling #384
Merged
Exclusive pooling #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eoghan1232
force-pushed
the
exclusive_pooling
branch
2 times, most recently
from
7a4d486
to
349a48c
Compare
|
LGTM 👍 |
|
Thanks @Eoghan1232 for working on the fix! |
zshi-redhat
approved these changes
Oct 19, 2021
|
Thanks for the PR ! It would be great if commit message contained a bit more info on the problem and how this PR solves it |
Eoghan1232
force-pushed
the
exclusive_pooling
branch
from
349a48c
to
45dddcd
Compare
|
@adrianchiris @zshi-redhat Updated implementation with Adrian's feedback. |
zshi-redhat
reviewed
Oct 25, 2021
|
nit: Could you please rebase and squash the commits into one? |
Eoghan1232
force-pushed
the
exclusive_pooling
branch
2 times, most recently
from
8bd470f
to
99d4b66
Compare
Done. |
|
@zshi-redhat @adrianchiris if you are okay also, I will proceed with the merge :) |
|
/lgtm |
|
one minor nit: could you update commit msg with abit more info on this change other than that LGTM |
Eoghan1232
force-pushed
the
exclusive_pooling
branch
from
99d4b66
to
e1434eb
Compare
Enabling validation that a VF is only used in one resource pool This will also bring tighter config maps to ensure VF are allocated correctly
Eoghan1232
force-pushed
the
exclusive_pooling
branch
from
e1434eb
to
7480390
Compare
|
Approved by @zshi-redhat, @adrianchiris and myself. |
adrianchiris
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to this:
#355
Enabling validation that a VF is only used in one resource pool.
signed off: eoghan.russell@intel.com