Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for excludeTopology config #425

Merged
merged 1 commit into from
May 10, 2022

Conversation

rthakur-est
Copy link
Contributor

Updated README to include documentation for "excludeTopology" config.
This config allows making advertising of device's NUMA toplogy optional.

#320

Signed-off-by: Ravindra Thakur ravindra.nath.thakur@est.tech

updated README to include documentation for "excludeTopology" config.
This config allows making advertising of device's NUMA toplogy optional.

Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@est.tech>
@rthakur-est
Copy link
Contributor Author

/cc @adrianchiris @Eoghan1232

Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is un-related

LGTM

should be merged once #416 is merged
should be merged once #

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eoghan1232
Copy link
Collaborator

@SchSeba are you happy to merge this too?

@adrianchiris adrianchiris merged commit 7189b34 into k8snetworkplumbingwg:master May 10, 2022
@zeeke
Copy link
Member

zeeke commented May 10, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants