Bump golang 1.18 and k8s 1.24 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchSeba
force-pushed
the
bump_to_golang_1.18_k8s_1.24
branch
from
f3adfad
to
f274c38
Compare
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
bump_to_golang_1.18_k8s_1.24
branch
from
f274c38
to
821d03f
Compare
Pull Request Test Coverage Report for Build 2428027201
💛 - Coveralls |
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
adrianchiris
approved these changes
Jun 6, 2022
e0ne
reviewed
Jun 6, 2022
| @@ -1,6 +1,6 @@ | |||
| module github.com/k8snetworkplumbingwg/sriov-network-device-plugin | |||
|
|
|||
| go 1.13 | |||
| go 1.17 | |||
There was a problem hiding this comment.
Why thre is 1.17 instead of 1.18?
There was a problem hiding this comment.
there is no 1.18 version in go.mod files yet
e0ne
reviewed
Jun 6, 2022
| @@ -5,13 +5,13 @@ jobs: | |||
| name: build | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.13.x, 1.14.x, 1.15.x, 1.16.x] | |||
| go-version: [1.17.x, 1.18.x] | |||
There was a problem hiding this comment.
Do we still need to support 1.17.x?
There was a problem hiding this comment.
I think it's in the build verification (we only publish 1.18 built container images)
adrianchiris
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Sch sebassch@gmail.com