-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang 1.18 and k8s 1.24 #431
Bump golang 1.18 and k8s 1.24 #431
Conversation
f3adfad
to
f274c38
Compare
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
f274c38
to
821d03f
Compare
Pull Request Test Coverage Report for Build 2428027201
💛 - Coveralls |
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@@ -1,6 +1,6 @@ | |||
module github.com/k8snetworkplumbingwg/sriov-network-device-plugin | |||
|
|||
go 1.13 | |||
go 1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why thre is 1.17 instead of 1.18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no 1.18 version in go.mod files yet
@@ -5,13 +5,13 @@ jobs: | |||
name: build | |||
strategy: | |||
matrix: | |||
go-version: [1.13.x, 1.14.x, 1.15.x, 1.16.x] | |||
go-version: [1.17.x, 1.18.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to support 1.17.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's in the build verification (we only publish 1.18 built container images)
Signed-off-by: Sebastian Sch sebassch@gmail.com