Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused methods #439

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

adrianchiris
Copy link
Contributor

No description provided.

This method is not being used. remove it to
keep code cleanliness.

Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
NUMA information is populated and consumed
via k8s plugin API Device. PciDevice.GetNumaInfo()
interface method is not used. remove it and related
code.

Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2022

Pull Request Test Coverage Report for Build 2685825096

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 76.765%

Totals Coverage Status
Change from base Build 2663118240: 0.3%
Covered Lines: 1566
Relevant Lines: 2040

💛 - Coveralls

@adrianchiris adrianchiris merged commit faafa1f into k8snetworkplumbingwg:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants