Updated dependency to govdpa v0.1.4 #450
Conversation
|
Hi, can anyone please help with the following:
/cc @zshi-redhat |
Pull Request Test Coverage Report for Build 3516750855Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lmilleri
force-pushed
the
vdpa
branch
2 times, most recently
from
62b2968
to
c450e35
Compare
|
@adrianchiris Please review or add relevant people in cc |
|
just one minor question on my side. @lmilleri can you rebase this PR ? |
lmilleri
force-pushed
the
vdpa
branch
3 times, most recently
from
78ad991
to
56a7b3d
Compare
|
/lgtm |
| if numVdpaDevices == 0 { | ||
| return nil, fmt.Errorf("no vdpa device associated to pciAddress %v", pciAddr) | ||
| } | ||
| if numVdpaDevices > 1 { |
There was a problem hiding this comment.
Is this a valid use-case?
should we always return the first one?
There was a problem hiding this comment.
Adrian asked the same question, please check comments above. Basically, there is only one vdpa device per pci-address in SRIOV. Anyway, the govdpa interface is more general and future proof for when sub-functions will be supported.
There was a problem hiding this comment.
Good that we ask the same questions :P
Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
A new release of govdpa library has been published (v.0.1.4), introducing new functionalities like add/remove vDPA devices and also significant changes to the public interface.
The current changes to the sriov-network-device-plugin are required to import govdpa v.0.1.4