-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependency to govdpa v0.1.4 #450
Conversation
Hi, can anyone please help with the following:
/cc @zshi-redhat |
Pull Request Test Coverage Report for Build 3516750855Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
62b2968
to
c450e35
Compare
@adrianchiris Please review or add relevant people in cc |
just one minor question on my side. @lmilleri can you rebase this PR ? |
78ad991
to
56a7b3d
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution the PR is almost ready to small nits and one question
if numVdpaDevices == 0 { | ||
return nil, fmt.Errorf("no vdpa device associated to pciAddress %v", pciAddr) | ||
} | ||
if numVdpaDevices > 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a valid use-case?
should we always return the first one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adrian asked the same question, please check comments above. Basically, there is only one vdpa device per pci-address in SRIOV. Anyway, the govdpa interface is more general and future proof for when sub-functions will be supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that we ask the same questions :P
Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
A new release of govdpa library has been published (v.0.1.4), introducing new functionalities like add/remove vDPA devices and also significant changes to the public interface.
The current changes to the sriov-network-device-plugin are required to import govdpa v.0.1.4