Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #454

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

nhennigan
Copy link

Update to list of Intel supported NICs and drivers. Linting on both files also.

Update to list of Intel supported NICs and drivers. Linting on both files also
@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2022

Pull Request Test Coverage Report for Build 3576150995

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.385%

Totals Coverage Status
Change from base Build 3559238490: 0.0%
Covered Lines: 1572
Relevant Lines: 2058

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks for the contribution!

btw k8s < 1.15 is not supported any more will it be possible to remove it from the docs?
I am fine if you want to do it in a separe PR

* Intel® Ethernet Controller X552
* Intel® Ethernet Controller X553

* Intel® Ethernet Network Adapter X722
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also add a list for the E810 supported nics?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added E810 NICs and also removed line about support for k8s <1.15

README.md Outdated Show resolved Hide resolved
@nhennigan
Copy link
Author

possible to remove it from the docs?
@SchSeba
No problem, I can remove the line pointing to deployments/k8s-v1.10-v1.15/sriovdp-daemonset.yaml for 1.15 k8s support. Is there also a need then to remove this file in this PR?

@SchSeba
Copy link
Collaborator

SchSeba commented Dec 18, 2022

Hi @nhennigan yes please remove the files if we don't point to them we don't need them :)

@nhennigan nhennigan merged commit 4146482 into k8snetworkplumbingwg:master Dec 20, 2022
@nhennigan nhennigan deleted the docs-update branch December 20, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants