Derive link type from PF if the interface name is not available #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4858418589Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
almaslennikov
force-pushed
the
derive-link-type-from-pf
branch
from
44eaf83
to
c92f7ac
Compare
|
/test-all |
1 similar comment
|
/test-all |
SchSeba
reviewed
Apr 23, 2023
almaslennikov
force-pushed
the
derive-link-type-from-pf
branch
3 times, most recently
from
323abb5
to
f104700
Compare
In case a workload is already consuming a VF and sriov-device-plugin is restarted, when this selector is specified, the device plugin will fail to get the VF link type since getting this information requires the VF netdev. The netdev does not exist in the host namespace as its assigned to pod. this causes sriov-network-device-plugin to fail adding this VF to resource pool, causing it to report the wrong number of resources. To fix this, derive the link type of the device from its PF, if the netdev itself is not available. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
derive-link-type-from-pf
branch
from
f104700
to
aa43530
Compare
e0ne
approved these changes
May 4, 2023
adrianchiris
approved these changes
May 4, 2023
SchSeba
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case a workload is already consuming a VF and sriov-device-plugin is restarted, when this selector is specified, the device plugin will fail to get the VF link type since getting this information requires the VF netdev. The netdev does not exist in the host namespace as its assigned to pod. This causes sriov-network-device-plugin to fail adding this VF to resource pool causing it to report the wrong number of resources.
To fix this, derive the link type of the device from its PF, if the netdev itself is not available.