Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go version to 1.20 #484

Merged
merged 2 commits into from
May 23, 2023

Conversation

Eoghan1232
Copy link
Collaborator

@Eoghan1232 Eoghan1232 commented May 23, 2023

bumping go version to 1.20.
#475 needs a go version greater than 1.17, SRIOV CNI is go 1.20, so updating to stay in line.

all these passed:

make build
make image
go test ./...

Eoghan Russell added 2 commits May 23, 2023 09:05
Signed-off-by: Eoghan Russell <eoghan.russell@intel.com>
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023

Pull Request Test Coverage Report for Build 5055437967

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.339%

Totals Coverage Status
Change from base Build 5046527304: 0.0%
Covered Lines: 1924
Relevant Lines: 2456

💛 - Coveralls

@Eoghan1232
Copy link
Collaborator Author

@SchSeba @adrianchiris PTAL

@Eoghan1232 Eoghan1232 mentioned this pull request May 23, 2023
@SchSeba SchSeba merged commit 8985a66 into k8snetworkplumbingwg:master May 23, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 5055400936

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.339%

Totals Coverage Status
Change from base Build 5046527304: 0.0%
Covered Lines: 1924
Relevant Lines: 2456

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants