-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set container device permissions to 'rw' #491
Conversation
Pull Request Test Coverage Report for Build 5412491197
💛 - Coveralls |
There is no need to create devices inside containers, so we don't need to add 'm' permissions.
I thought the scope of the PR in RDMA. Did you tested for the other cases as well? (vdpa vfio ... ) |
I tested rdma devices with PF and VFs and also verified that SFs are not affected |
if u have time to test it for VFIO / UIO would be great ! the benefit is providing workloads less permissions over mounts as they dont require them. |
@SchSeba @Eoghan1232 any update on this one ? |
Hi @adrianchiris just tested it with vfio-pci driver now, it works as expected, no issues.
|
Pull Request Test Coverage Report for Build 5412491197Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There is no need to create devices inside containers, so we don't
need to add 'm' permissions.