Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump grpc and glog #495

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Bump grpc and glog #495

merged 2 commits into from
Jul 20, 2023

Conversation

adrianchiris
Copy link
Contributor

No description provided.

@adrianchiris
Bump grpc and glog versions to latest release
f40e056 
Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris
Replace deprecated grpc WithInsecure()
ecb3fac 
Use recommended alternative instead

Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris
Copy link
Contributor Author

replaces #494

@adrianchiris
Copy link
Contributor Author

//cc @Eoghan1232 @zeeke

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5610847147

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.24%
Totals Coverage Status
Change from base Build 5610622993: 0.02%
Covered Lines: 1956
Relevant Lines: 2500
💛 - Coveralls

Eoghan1232
Eoghan1232 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrianchiris adrianchiris merged commit 31774fd into k8snetworkplumbingwg:master Jul 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianchiris @coveralls @Eoghan1232