Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Broadcom NICs #510

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add support for Broadcom NICs #510

merged 1 commit into from
Nov 28, 2023

Conversation

roman-brcm
Copy link
Contributor

We have verified that SRIOV plugin works with Broadcom NICs. This request is adding Broadcom NICs to Readme and adding an example of a working configuration.

README.md Outdated
@@ -198,6 +199,15 @@ This plugin creates device plugin endpoints based on the configurations given in
"needVhostNet": true
}]
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add at the end of the list before: "old_selectors_syntax_example"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@@ -23,6 +23,14 @@ data:
"pfNames": ["enp0s0f0","enp2s2f1"]
}
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add at the end of the list

@adrianchiris
Copy link
Contributor

minor nit, otherwise LGTM ! thx for testing it out of broadcom

@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6946547658

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.628%

Totals Coverage Status
Change from base Build 6651326088: 0.0%
Covered Lines: 2017
Relevant Lines: 2667

💛 - Coveralls

@roman-brcm
Copy link
Contributor Author

I have pushed requested changes.

@roman-brcm
Copy link
Contributor Author

@adrianchiris Thank you very much for the review and approval. Can you please merge?

@adrianchiris
Copy link
Contributor

communitiy rules requires 2 approvals.

@zeeke @Eoghan1232 PTAL

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eoghan1232 Eoghan1232 merged commit 92f00b5 into k8snetworkplumbingwg:master Nov 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants