Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new tasks, fix task bugs and improve testing #584

Merged
merged 12 commits into from
Oct 20, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 11, 2023

What this PR does:

  • Implements new task types, scrub, compaction, flush and garbagecollect
  • Improves testing of tasks with ability to verify workload sent to the management-api
  • Fix some bugs related to sync tasks
  • Modify TaskConditions to be metav1.Conditions instead of JobConditions. This is backwards compatible in YAML format.

Which issue(s) this PR fixes:
Fixes #578
Fixes #580
Fixes #586
Fixes #585
Fixes #582

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner October 11, 2023 17:43
@burmanm
Copy link
Contributor Author

burmanm commented Oct 11, 2023

Can't find the Draft button.. ouh well. This is still missing scrub & compact tasks + CHANGELOG updates.

@adejanovski adejanovski marked this pull request as draft October 12, 2023 06:11
@adejanovski
Copy link
Contributor

Draft button is at the top right, under reviewers ;)

I did turn it into a draft.

…bCondition. Also, fix sync pod annotations to patch the correct instance. Modify the task Validator to mark the task as Failed instead of retrying until the task is fixed (and only logging to cass-operator logs why it is failing).
…ueue causing a matching timing with the pod delete (before recreate). Also, implement scrub and compaction calls.
… tasks envtests by allowing to verify the payload sent to the management-api
@burmanm burmanm changed the title Implement new tasks Implement new tasks, fix task bugs and improve testing Oct 16, 2023
@burmanm burmanm closed this Oct 16, 2023
@burmanm burmanm reopened this Oct 16, 2023
@burmanm burmanm marked this pull request as ready for review October 16, 2023 11:17
@burmanm
Copy link
Contributor Author

burmanm commented Oct 17, 2023

The test failures are expected until 0.6.70 from mgmt-api is released.

@burmanm burmanm merged commit bd3c39f into k8ssandra:master Oct 20, 2023
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants