Updaet DSE image builds based on docker-images #208
Conversation
emerkle826
force-pushed
the
dse-docker
branch
from
789620a to
381516d
Compare
emerkle826
force-pushed
the
dse-docker
branch
from
381516d to
e82c357
Compare
| @@ -0,0 +1,180 @@ | |||
| # Copyright DataStax, Inc, 2017 | |||
There was a problem hiding this comment.
All of the Docker build files were generated from the docker-images repo with the changes from this PR:
https://github.com/riptano/docker-images/pull/87
There are some slight modifications to the build files as that PR will add a released Management API bundle to the DSE image, where the files in this PR will compile the latest Management API bundles and add them to the images built in this repo.
| @@ -131,6 +131,9 @@ jobs: | |||
| if: ${{ github.ref == 'refs/heads/master' && github.event_name == 'push'}} | |||
| needs: build-dse | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| jdk-version: [jdk8, jdk11] | |||
There was a problem hiding this comment.
Do we need the jdk8 builds?
There was a problem hiding this comment.
We don't necessarily, but I believe the cass-operator default DSE image is a JDK8 based image. The official DSE images have a -java11 suffix to the image tag for JDK11 based images, while the JDK8 based images do not have a suffix for the tag.
There was a problem hiding this comment.
Also, the DSE images aren't official, just used for testing at the moment. But it doesn't hurt to build both as the official build process will.
Updates the DSE image builds to match (as closely as possible) the official builds for DSE Docker images with Management API embedded.
Fixes: #209