implement persistent debugLevel #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DebugLevel('debug', true);'
dpwspoon
reviewed
Aug 22, 2017
lib/configuration.js
Outdated
| localStorage.setItem(_DEBUG_LEVEL_KEY, _DEBUG_LEVEL_DEFAULT); | ||
| } | ||
|
|
||
| // Compute default value from storet then const |
|
What's the use case for this and do we need this? |
|
I think we should formalize on the README how we want logging to work. It is unclear to me how we want it to work long-term and with what API. If the API changes on this PR are not what we want long term then we should indicate that it is private/subject to change, perhaps by making it not enumerable (maybe it already is, or adding _, or etc/thoughts?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement persistent debugLevel via setDebugLevel second argument persist.
Use localStorage when available or private in memory as fallback.