Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JavaScript target code template. #17

Merged
merged 1 commit into from Mar 7, 2021
Merged

Improve JavaScript target code template. #17

merged 1 commit into from Mar 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2021

TODO:

  • Wait for ANTLR version and update dependency, so we can avoid those bugs in JS runtime.
  • Improve other code template.
  • Use file (or whole directory) as template, so we needn't hard code them in C# code.

@kaby76 kaby76 merged commit bc63de0 into kaby76:master Mar 7, 2021
@kaby76
Copy link
Owner

kaby76 commented Mar 7, 2021

I'm going to need to rewrite the code sooner than later to use StringTemplates. I posted some runtimes in Antlr4 issues and have asked to add in warm-up code. I don't want to just update the WriteLine implementation with yet another option switch on the command line for "performance testing", because I always anticipated this would all be throw-away code. So, I'm going to now make a branch "StringTemplates" that will contain the rewrite. I hope to rewrite that over the next couple days. At that point, it will come with some default templates, but folks can override that with their own templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant