Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign JSON transactions with ledger & Search for Ledger Keys Pro #68

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

Takadenoshi
Copy link
Contributor

Added two new pages:

  • Signing arbitrary JSON transactions via ledger. This uses the signTransaction API, not the hash sign API, so the ledger shows all the details nicely. The page attempts to detect:

    • if the right key is selected to sign (and complain otherwise)
    • if all signers have signed, it offers to submit the txn as well
  • Search for Ledger Key

    • Allows iterating the available keys/paths on the Ledger to find a key/specific address, or a key prefix

Minor Changes:

  • Added error warning for Firefox - does not support HID. Probably need one for Safari as well.
  • Build a small sub page for the 3 ledger tools, homepage now has "Ledger Tools" button that goes to it.

Preview: https://sign-json-ledger.kdtjs4taka.pages.dev/ledger

docs/ledger-keys.html Outdated Show resolved Hide resolved
docs/ledger-keys.html Outdated Show resolved Hide resolved
@Takadenoshi Takadenoshi merged commit 55d53e0 into kadena-community:master Oct 19, 2023
@Takadenoshi
Copy link
Contributor Author

Added: bugfix for ledger hash signing - the sigs were not encoded correctly

@Takadenoshi Takadenoshi deleted the sign-json-ledger branch October 19, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants