Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New LSP #12

Merged
merged 4 commits into from
May 29, 2024
Merged

New LSP #12

merged 4 commits into from
May 29, 2024

Conversation

salamaashoush
Copy link
Member

@salamaashoush salamaashoush commented Apr 28, 2024 •
edited
Loading

Changes

  • Bring the repo back to life and follow kadena.js setup (pnpm, vitest, eslint, tsup).
  • Add PR CI checks.
  • Use pactup to automatically install pact 5 developments releases.
  • Format and lint all files to following kadena.js standards.
  • Add vscode command to restart pact lsp

EnoF
EnoF reviewed May 1, 2024
View reviewed changes
src/languageclient.ts Outdated
const traceOutputChannel = window.createOutputChannel('Pact Language Server trace');
// eslint-disable-next-line prefer-const
let { versionInfo, isInstalled } = await getPactInstallationInfo({ nightly: true });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should default to nightly builds. I think most devs would prefer the latest stable version

Copy link
Member Author

@salamaashoush salamaashoush May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new LSP is not available in the stable version pact4x and the plan is to use development builds of pact5 until it is released and then we can switch

@trendzetter
Copy link
Contributor

Do you mind splitting this in separate PR's by concern? formatting, update dependencies, ..

@salamaashoush salamaashoush marked this pull request as ready for review May 28, 2024 22:52
@Randynamic Randynamic merged commit 7f407a9 into main May 29, 2024
5 checks passed
@Randynamic Randynamic deleted the new-lsp branch May 29, 2024 09:40
@trendzetter trendzetter mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnoF EnoF EnoF approved these changes

@Randynamic Randynamic Awaiting requested review from Randynamic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salamaashoush @trendzetter @EnoF @Randynamic