Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile to ES2015 syntax #72

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

nikolaik
Copy link
Contributor

@nikolaik nikolaik commented Feb 14, 2021

After #71 we stopped transpiling object spread properties, which are used here. Setting target to es2015 maintains support for less modern browsers (still dropping the EOL IE11 browser).

When not setting target esbuild would transpile to esnext which skips transpiling spread properties, among other things.

Ref: https://esbuild.github.io/content-types/#javascript

When not setting target esbuild transpiles to `esnext` which would skip
transpiling spread properties, among other things.

Ref: https://esbuild.github.io/content-types/#javascript
Copy link
Owner

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! 👍

@kadikraman kadikraman merged commit 3a829e9 into kadikraman:master Feb 14, 2021
@kadikraman
Copy link
Owner

Published as a patch 😊 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants