Merge pull request #11 from TheDiscordian/SignificantlyLessHTTPCalls

Only do HTTP calls if player has perms, only do one
kadotcom · Mar 14, 2024 · 9984747 · 9984747
2 parents 31c94da + 934cbb0
commit 9984747
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/me/kadotcom/lifestolen/Events/LifeStealEvent.java b/src/main/java/me/kadotcom/lifestolen/Events/LifeStealEvent.java
@@ -119,9 +119,10 @@ public void onPlayerJoin(PlayerJoinEvent event) {
             HealthManager.setMaxHealth(plugin.getConfig().getInt("HP.startHP"), event.getPlayer());
         }
 
-        if(!HTTP.get("https://api.spigotmc.org/legacy/update.php?resource=99220").equalsIgnoreCase(plugin.getDescription().getVersion()) && !plugin.getDescription().getVersion().contains("Tested")){
-            if(event.getPlayer().isOp() || event.getPlayer().hasPermission(plugin.getConfig().getString("permissions.messages.outdatedPermissionMessage"))){
-                event.getPlayer().sendMessage("§f[§cLifeStolen§f] There is a new version of LifeStolen.\nYou are on "+ plugin.getDescription().getVersion() +" while the newest version is " + HTTP.get("https://api.spigotmc.org/legacy/update.php?resource=99220") + ".\nYou can get the newest version here. https://www.spigotmc.org/resources/lifestolen.99220/");
+        if(event.getPlayer().isOp() || event.getPlayer().hasPermission(plugin.getConfig().getString("permissions.messages.outdatedPermissionMessage"))){
+            String version = HTTP.get("https://api.spigotmc.org/legacy/update.php?resource=99220");
+            if(!version.equalsIgnoreCase(plugin.getDescription().getVersion()) && !plugin.getDescription().getVersion().contains("Tested")){
+                event.getPlayer().sendMessage("§f[§cLifeStolen§f] There is a new version of LifeStolen.\nYou are on "+ plugin.getDescription().getVersion() +" while the newest version is " + version + ".\nYou can get the newest version here. https://www.spigotmc.org/resources/lifestolen.99220/");
             }
         }