Integrated both our changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
This was referenced Mar 7, 2021
Closed
Closed
Closed
remark fixed minor issue on hierarchicalTags check Signed-off-by: mathis-m <mathis.michel@outlook.de>
kael-shipman
reviewed
Mar 8, 2021
| } = this.props | ||
|
|
||
| // Note returns now optional filtered and optional hierarchical structure, in case user has set config accordingly | ||
| const taggedOps = specSelectors.taggedOperations() |
There was a problem hiding this comment.
I like this approach! This makes a lot of sense to me. That said, it also introduces a major, backward-incompatible change, so it may not fly.... As with the rest of this, though, I say let's go for it and see what Tim thinks. If he asks us to factor it into a hierarchy-specific selector, we can do that then.
(This is not a blocker, just an idle comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did end up pulling the renderChildTags into the operations component. with this the new copy and paste hierarchical-operations-tag component is obsolete. So we dont end up with duplicate code base.