Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type for parse() #45

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix type for parse() #45

merged 1 commit into from
Jul 4, 2024

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Jun 20, 2024 •
edited
Loading

Closes #44

It appears that the 2nd argument of parse() (reviver) can also be null, from the examples in the readme and also src/parse.js:

node-comment-json/src/parse.js

Line 53 in 4416b4d

let reviver = null

@karlhorky karlhorky changed the title Fix type for parse() Fix type for parse() Jun 20, 2024
@kaelzhang kaelzhang merged commit 02de76e into kaelzhang:master Jul 4, 2024
kaelzhang added a commit that referenced this pull request Jul 4, 2024
@kaelzhang
#45: bump version 4.2.4
6e774bb
@kaelzhang
Copy link
Owner

Thanks. Landed in 4.2.4

@karlhorky
Copy link
Contributor Author

Glad to help, thanks for the review, merge and publish!

@karlhorky karlhorky deleted the patch-1 branch July 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong type usage in examples
2 participants
@karlhorky @kaelzhang