Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: KC: Fix connector listing with STOPPED state #511

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

developster
Copy link
Contributor

@developster developster commented Jul 30, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #510

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@developster developster requested a review from a team as a code owner July 30, 2024 08:09
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi developster! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working area/connect Kafka Connect, its connectors and removed status/triage/manual Manual triage in progress labels Jul 30, 2024
@Haarolean Haarolean self-assigned this Jul 30, 2024
@Haarolean Haarolean changed the title BE: Add STOPPED connector state (#510) BE: KC: Fix connector listing with STOPPED state Jul 30, 2024
@Haarolean Haarolean merged commit 7720cc2 into kafbat:main Aug 1, 2024
46 of 48 checks passed
@Haarolean
Copy link
Member

@developster thanks for your first contribution to kafbat UI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connect Kafka Connect, its connectors scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KC: Listing fails w/ connectors in STOPPED state
2 participants