Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Spring Boot 3.3.4 #606

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sixdouglas
Copy link

@sixdouglas sixdouglas commented Oct 13, 2024

Bump several frameworks versions

  • [?] Breaking change? (if so, please describe the impact and migration path for existing application instances)

I don't know why yet, but make this PropertyResolverImplTest test pass, I needed to change the CustomPropertiesClass to a record! I'm still looking on this issue, though the functionality of mapping properties to custom classes is not used in the kafka-ui project.

I also had to change a little something in the KsqlApiClientTest test since Jackson now return DoubleNode instead of DecimalNode. Don't know why either.

I let you decide if these differences are breaking changes.

What changes did you make? (Give an overview)

Bump framework versions

  • mapstruct : 1.5.5.Final -> 1.6.2

  • lombok : 1.18.32 -> 1.18.34

  • snakeyaml : 2.2 -> 2.3

  • spring-boot : 3.1.9 -> 3.3.4

  • json : 20231013 -> 20240303

  • guava : 33.0.0-jre -> 33.3.1-jre

  • junit : 5.9.1 -> 5.11.2

  • testcontainers : 1.19.5 -> 1.20.2

Is there anything you'd like reviewers to focus on?

All unit tests are OK on my machine, but the smoke tests from the prod profile are not. They are failing with this error:

Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/[0:0:0:0:0:0:0:1]:8080
Caused by: java.net.ConnectException: Connection refused

I followed the Build and Run with Docker tutorial, the app works locally! I can navigate and see the topics, their characteristics and their content without any issues in the logs as in the UI.

@Haarolean maybe you help me figure out what happens or at least give me some hints on where to look for details?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

- mapstruct : 1.5.5.Final -> 1.6.2
- lombok : 1.18.32 -> 1.18.34
- snakeyaml : 2.2 -> 2.3
- spring-boot : 3.1.9 -> 3.3.4
- json : 20231013 -> 20240303
- guava : 33.0.0-jre -> 33.3.1-jre

- junit : 5.9.1 -> 5.11.2
- testcontainers : 1.19.5 -> 1.20.2
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sixdouglas! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@sixdouglas
Copy link
Author

This PR can help #490 issue

@sixdouglas
Copy link
Author

It looks like I didn't start the docker compose before running the smoke-tests.
This explains the Connection refused error I got.
Now I have the Container compose-kafka-connect0-1 that fails to start.
Still work in progress

@Haarolean
Copy link
Member

It looks like I didn't start the docker compose before running the smoke-tests. This explains the Connection refused error I got. Now I have the Container compose-kafka-connect0-1 that fails to start. Still work in progress

I've run the tests here, in CI, nothing (new) fails.
Can you please run trivy on your branch so we can take a look if removing deps overrides introduced new CVEs?

- logback : 1.4.5 -> 1.4.12
- avro : 1.11.3 -> 1.11.4
@sixdouglas
Copy link
Author

In deed! I've rollback the changes for CVE. The report looks really good.

trivy.json

Back to:
- logback : 1.4.12 -> 1.5.8
@sixdouglas
Copy link
Author

Sorry about my last commit, Spring Boot uses now the 1.5.8 version of Logback, so no need to change its version

@sixdouglas
Copy link
Author

the trivy report still looks good

trivy.json

@sixdouglas sixdouglas marked this pull request as ready for review October 15, 2024 07:02
@sixdouglas sixdouglas requested a review from a team as a code owner October 15, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants