Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ffmpeg crashes #15

Closed
wants to merge 4 commits into from
Closed

Conversation

YpNo
Copy link
Contributor

@YpNo YpNo commented Jan 28, 2024

Fixing ffmpeg crashes in _start_stream function + Supporting HLS/Dash protocol
Fix #13

@kaffetorsk
Copy link
Owner

kaffetorsk commented Jan 28, 2024

Thanks for PR

Lot of changes here, can you describe what fail there is in _start_stream() and why?

PS: What kind of camera are you using?

@YpNo
Copy link
Contributor Author

YpNo commented Jan 28, 2024

Explained in issue discussion.

I've used Arlo Pro 4 Cameras and 1 Arlo Doorbell essential.

@YpNo
Copy link
Contributor Author

YpNo commented Jan 31, 2024

Hi,
I reviewed my PR due to high cpu load because of ffpmeg video transcoding for the idle stream.
I've reduce the modifications on ffpmeg options. I think the main issue have came from audio format.

@YpNo
Copy link
Contributor Author

YpNo commented Feb 10, 2024

Hi @kaffetorsk,

Do you think we can merge this PR ?
I saw you have closed the issue.

If you want to optimize what I did, please do :)

Regards

@kaffetorsk
Copy link
Owner

I'm rejecting this PR for several reasons:

  1. Too many changes that are somewhat randomly grouped together.
  2. When asked why you changed the ffmpeg params, the answer was basically that you just tried different combinations.
  3. I cannot replicate your issue, i don't think this repo is to blame, else other users would chime in
  4. FFMPEG version is set in order to support SRT.
  5. bsf dump_extra is needed to keep the proxy stream alive while switching pipe input.

@kaffetorsk kaffetorsk closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active stream is never triggered
2 participants