Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Confluent RBAC #11

Closed
purbon opened this issue Feb 2, 2020 · 0 comments · Fixed by #13
Closed

Add support for Confluent RBAC #11

purbon opened this issue Feb 2, 2020 · 0 comments · Fixed by #13
Milestone
v1.0

Comments

@purbon
Copy link
Collaborator

purbon commented Feb 2, 2020

As a user of the Topology Builder I would like to be able to leverage the new RBAC functionality provided by Confluent. See https://docs.confluent.io/current/security/rbac/index.html

This future can be leverage by using the MDS Api, see https://docs.confluent.io/current/security/rbac/mds-api.html or the confluent CLI. There is a preference for the API driven approach.
@purbon purbon mentioned this issue Feb 20, 2020
Merged
@purbon purbon added this to the v1.0 milestone Oct 5, 2020
sverrehu referenced this issue in sverrehu/julie Sep 7, 2021
@sverrehu
Rewrite deprecated code (#11)
bd9bb68
purbon pushed a commit that referenced this issue Dec 10, 2021
@akselh @sverrehu
Improved execution log for topics and schemas (#383)
39d2e30 
* Refactor SyncTopicAction 

Split SyncTopicAction into separate actions for the different parts: create topic, update config and update schema reg

* Only change topic configs that are actually changed

Create a topic config update plan for the UpdateTopicConfigAction. And let the adminClient only update according to the plan.

* run -> buildAndExecutePlan

* applyCreate -> updatePlanWithPrincipalsCreation

* apply -> updatePlan

* applyDelete -> updatePlanWithPrincipalsDeletion

* Auto-format

* Spelling

* bindings -> aclBindings

* Make methods private. Add @OverRide annotations. Implement ManagerOfThings

* ManagerOfThings -> ExecutionPlanUpdater

* Make PrincipalManager an ExecutionPlanUpdater and simplify the plan update process

* Revert "bindings -> aclBindings"

This reverts commit 00bc474.

* Explicit method calls per manager

* buildAndExecutePlan -> run, as per review request.

* Split PrincipalManager in two, as per review request.

* Make method private

* Remove unnecessary throws clause

* dryRun: Only log actual topic config changes

Log details on the actual topic config changes that will be done. Also fixed logic for detecting new configs added.

* Renamed and fixed test for partition count update.

* Remove comments

* Test TopicConfigUpdatePlanBuilder and fix a bug (#12)

Test logic for detecting new, updated and removed topic configs.

* Rewrite deprecated code (#11)

* Refactor bindings building (#6)

* Merge upstream master and fix issues

* Add both localhost and host.docker.internal to the cert, to make it usable on dind on Windows

* Code style reformatting

* Improve RegisterSchemaAction output

* Print output for both dryrun and apply phases

* Make log output format consistent for create and delete topic actions

Co-authored-by: Sverre H. Huseby <shh@thathost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

[WiP]Add support for Confluent RBAC kafka-ops/julie
1 participant
@purbon