Quotas implementation, only quotas based in user principal #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedillomarcos
force-pushed
the
feat/quotas
branch
from
02746e7 to
bf8212a
Compare
|
Thanks for your contribution @cedillomarcos , I really appreciate it! i will be reviewing soon and providing you with feedback, thanks a lot again for the time willing to help. |
purbon
reviewed
Nov 9, 2021
purbon
changed the title
purbon
added a commit
that referenced
this pull request
Dec 9, 2021
* Resolve #25: Quotas implementation, only quotas based in user principal * Add doc usage of quotas Co-authored-by: Pere Urbón <purbon@users.noreply.github.com> Co-authored-by: Marcos Martinez Cedillo <marcos.martinez@orangebank.es>
purbon
added a commit
that referenced
this pull request
Dec 9, 2021
* Resolve #25: Quotas implementation, only quotas based in user principal * Add doc usage of quotas Co-authored-by: Pere Urbón <purbon@users.noreply.github.com> Co-authored-by: Marcos Martinez Cedillo <marcos.martinez@orangebank.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: Add quotas support for clients user principal connections, where you can add a consumer, or producer, or request_rate percent quota.
What is the current behavior? (You can also link to an open issue here)
Not implemented feat in Julie.
What is the new behavior (if this is a feature change)?
Now, can add a config file (yaml...) in a new section inside platform/kafka ...
platform: kafka: quotas: - principal: "User:App0" producer_byte_rate: 1024 consumer_byte_rate: 1024 request_percentage: 50.0 - principal: "User:App1" producer_byte_rate: 2048 consumer_byte_rate: 2048 - principal: "User:App2" request_percentage: 80.0Not changes might the users do, it's a separate feat...
close #25