feat: add exactly-once to kstreams and create transactionalid ACLs #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purbon
reviewed
Nov 11, 2021
src/main/java/com/purbon/kafka/topology/actions/access/builders/BuildBindingsForKStreams.java
Outdated
Show resolved
Hide resolved
|
Amazing work @jeqo thanks a lot! only left a cosmetic comment, looking forward to merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #387
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature Kafka Streams should include exactly-once option to add ACL for transactional IDs #387
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Backward compatible. Flag is disable by default.