Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: socket write error should not result in a crash report #124

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

zmstone
Copy link
Contributor

@zmstone zmstone commented Aug 27, 2024

When socket is closed writing data to it would result in a einval error.
In this case the tcp_closed and ssl_closed message are likely already in the mailbox,
this should not result in a crash report, so change it to a {shutdown, _} reason instead.

e.g. from proc_lib:crash_report/4:

error_logger: {"type":"crash_report","tag":"error_report"}, logger_formatter: {"title":"CRASH REPORT"}, msg: crasher: initial call: kpro_connection:init/4, pid: <0.12144989.0>, registered_name: [], exit: {{send_error,[{api,produce},{vsn,7},{caller,<0.1983516.0>},{reason,einval}]}

@zmstone zmstone merged commit e44c9ac into kafka4beam:master Aug 27, 2024
6 checks passed
@zmstone zmstone deleted the 0827-fix-einval-crash branch August 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants