Skip to content

Commit

Permalink
Fix path issues when restarting on configmap changes (#79)
Browse files Browse the repository at this point in the history
* Minor fixes for Burnell compat

* Fix path issues when restarting on configmap changes
  • Loading branch information
cdbartholomew authored Nov 13, 2020
1 parent 4e08145 commit f091aae
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
cluster: {{ template "pulsar.fullname" . }}
annotations:
{{- if .Values.restartOnConfigMapChange.enabled }}
checksum/config: {{ include (print $.Template.BasePath "/broker-configmap.yaml") . | sha256sum }}
checksum/config: {{ include (print $.Template.BasePath "/broker-deployment/broker-configmap.yaml") . | sha256sum }}
{{- end }}
{{ toYaml .Values.broker.annotations | indent 8 }}
spec:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
cluster: {{ template "pulsar.fullname" . }}
annotations:
{{- if .Values.restartOnConfigMapChange.enabled }}
checksum/config: {{ include (print $.Template.BasePath "/brokerSts-configmap.yaml") . | sha256sum }}
checksum/config: {{ include (print $.Template.BasePath "/broker-sts/broker-sts-configmap.yaml") . | sha256sum }}
{{- end }}
{{ toYaml .Values.brokerSts.annotations | indent 8 }}
spec:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
publishNotReadyAddresses: "true"
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
{{- if .Values.restartOnConfigMapChange.enabled }}
checksum/config: {{ include (print $.Template.BasePath "/state-configmap.yaml") . | sha256sum }}
checksum/config: {{ include (print $.Template.BasePath "/deprecated/state-configmap.yaml") . | sha256sum }}
{{- end }}
{{ toYaml .Values.stateStorage.annotations | indent 8 }}
spec:
Expand Down
2 changes: 1 addition & 1 deletion helm-chart-sources/pulsar/templates/proxy-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ spec:
- name: KeyFile
value: /pulsar/certs/tls.key
- name: TrustStore
value: {{ .Values.burnell.trustStore }}
value: {{ .Values.burnell.trustStore | default "/pulsar/certs/ca.crt" }}
{{- end }}
- name: FederatedPromURL
value: {{ .Values.burnell.federatedPromUrl }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
cluster: {{ template "pulsar.fullname" . }}
annotations:
{{- if .Values.restartOnConfigMapChange.enabled }}
checksum/config: {{ include (print $.Template.BasePath "/zookeeper-configmap.yaml") . | sha256sum }}
checksum/config: {{ include (print $.Template.BasePath "/zookeeper-nonpersist/zookeeper-configmap.yaml") . | sha256sum }}
{{- end }}
{{ toYaml .Values.zookeepernp.annotations | indent 8 }}
spec:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
cluster: {{ template "pulsar.fullname" . }}
annotations:
{{- if .Values.restartOnConfigMapChange.enabled }}
checksum/config: {{ include (print $.Template.BasePath "/zookeeper-configmap.yaml") . | sha256sum }}
checksum/config: {{ include (print $.Template.BasePath "/zookeeper/zookeeper-configmap.yaml") . | sha256sum }}
{{- end }}
{{ toYaml .Values.zookeeper.annotations | indent 8 }}
spec:
Expand Down
6 changes: 4 additions & 2 deletions helm-chart-sources/pulsar/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,9 @@ image:
pullPolicy: IfNotPresent
tag: 0.23.21
burnell:
repository: kafkaesqueio/burnell
repository: kesque/burnell
pullPolicy: Always
tag: 0.2.6
tag: 1.2.54
burnellLogCollector:
repository: kafkaesqueio/burnell-logcollector
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -1117,6 +1117,8 @@ tardigrade:
port: 7777
type: ClusterIP

# Placeholder for Burnell config options
burnell: {}

stateStorage:
component: statestorage
Expand Down

0 comments on commit f091aae

Please sign in to comment.