Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging a bit more informational #323

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

cdegroot
Copy link
Contributor

I was debugging some kafka_ex using code and noticed that what was logged wasn't really helping me. Some things I changed to help me find my coding mistake quicker:

  • In terminate/2, log the reason. Nine times out of ten, termination is because of something crashing and the reason has the details;
  • Log the partition when a leader is not there because leaders are per topic/partition, not per topic;
  • Log the function that logs the missing leader, as there are three identical error messages and that makes it hard to figure our where in the flow things are going wrong.

@sourcelevel-bot
Copy link

Hello, @cdegroot! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshuawscott joshuawscott merged commit cb590ed into kafkaex:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants