Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.8.1 warnings could be removed #343

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

gorenje
Copy link

@gorenje gorenje commented Mar 19, 2019

I get some warnings using 1.8.1:

warning: invalid type annotation. When using the | operator to represent the union of types, make sure to wrap type annotations in parentheses: nil | number | opts :: Keyword.t()
  lib/kafka_ex/server.ex:232

and

warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  config/config.exs:60

warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  config/config.exs:61

warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  config/config.exs:62

this would remove them but dunno what it does on other Elixir versions.

Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for cleaning this up!

@bjhaid
Copy link
Member

bjhaid commented Mar 19, 2019

can you add 1.8.1 to the mix here:

kafka_ex/.travis.yml

Lines 10 to 25 in 3c1eaf8

include:
- elixir: 1.7.4
otp_release: 21.1
- elixir: 1.6.6
otp_release: 20.2
- elixir: 1.5.3
otp_release: 20.2
- elixir: 1.4.5
otp_release: 19.3
env: COVERALLS=true CREDO=true
- elixir: 1.3.4
otp_release: 19.3
- elixir: 1.2.6
otp_release: 18.3
- elixir: 1.1.1
otp_release: 18.3

❤️

@gorenje
Copy link
Author

gorenje commented Mar 19, 2019

Thank you for a great package :)

@bjhaid bjhaid merged commit 455fb65 into kafkaex:master Mar 19, 2019
@joshuawscott joshuawscott mentioned this pull request Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants