Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kayrock auto commit behavior on empty results #387

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

dantswain
Copy link
Collaborator

Was trying to auto commit when the message set was empty, which would
result in the 'last offset' being nil.

Was trying to auto commit when the message set was empty, which would
result in the 'last offset' being nil.
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dantswain dantswain merged commit 188da6d into master Nov 24, 2019
@dantswain dantswain deleted the fix_kayrock_auto_commit_on_empty branch November 24, 2019 15:25
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants