Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test other branch #394

Merged
merged 1 commit into from
Jan 11, 2020
Merged

test other branch #394

merged 1 commit into from
Jan 11, 2020

Conversation

getong
Copy link
Contributor

@getong getong commented Jan 11, 2020

test elixir 1.9

dantswain
dantswain requested changes Jan 11, 2020
View reviewed changes
Copy link
Collaborator

@dantswain dantswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to duplicate builds for pull requests. My recommendation for if you want to build a branch without opening a pull request is to temporarily make this change but remove it before opening the pull request.

Testing against Elixir 1.9 is 👍 though.

@getong
Copy link
Contributor Author

getong commented Jan 11, 2020

done.

@dantswain dantswain merged commit dad8de9 into kafkaex:master Jan 11, 2020
@getong getong deleted the test-elixir-1.9 branch January 11, 2020 17:27
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantswain dantswain dantswain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getong @dantswain