Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout errors: ensure version of OTP in CI + document in README #405

Merged
merged 1 commit into from
May 7, 2020
Merged

Timeout errors: ensure version of OTP in CI + document in README #405

merged 1 commit into from
May 7, 2020

Conversation

jbruggem
Copy link
Collaborator

Closes #389

sourcelevel-bot[bot]
sourcelevel-bot bot reviewed Apr 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
sourcelevel-bot[bot]
sourcelevel-bot bot reviewed Apr 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jbruggem jbruggem force-pushed the fix_389_timeout_errors branch from 01326dc to cefde6d Compare April 27, 2020 14:19
joshuawscott
joshuawscott approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jbruggem
Copy link
Collaborator Author

@joshuawscott alas, we'll have to wait for OTP 21.3.8.15 to be released; travis can't find it.

I think OTP's CI failed when it tried to do the release

@dantswain
Copy link
Collaborator

I will approve this so hard once the build passes. This is truly heroic work 😭

@jbruggem jbruggem force-pushed the fix_389_timeout_errors branch from cefde6d to 21ee1a5 Compare April 27, 2020 14:51
@jbruggem jbruggem force-pushed the fix_389_timeout_errors branch 2 times, most recently from 1c27407 to b2aac7b Compare May 6, 2020 07:16
@jbruggem jbruggem force-pushed the fix_389_timeout_errors branch from b2aac7b to b406ea7 Compare May 6, 2020 08:09
@jbruggem
Copy link
Collaborator Author

jbruggem commented May 6, 2020

I removed 21.3.8.15 from the CI, since it's still not available. We now use either OTP 20 or OTP 22.

Works like a charm :). @dantswain you wanted to approve this ? :)

dantswain
dantswain approved these changes May 6, 2020
View reviewed changes
Copy link
Collaborator

@dantswain dantswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

bjhaid
bjhaid approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@bjhaid bjhaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks!

@jbruggem jbruggem merged commit 9255704 into kafkaex:master May 7, 2020
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcelevel-bot sourcelevel-bot[bot] sourcelevel-bot[bot] left review comments

@bjhaid bjhaid bjhaid approved these changes

@dantswain dantswain dantswain approved these changes

@joshuawscott joshuawscott joshuawscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout errors
4 participants
@jbruggem @dantswain @joshuawscott @bjhaid