Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coveralls #423

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Remove Coveralls #423

merged 1 commit into from
Jan 7, 2021

Conversation

dantswain
Copy link
Collaborator

We're not really paying attention to it and it causes spurrious test
failures

I left the coveralls dependency because it generates a nice coverage report locally and personally I do find that useful.

We're not really paying attention to it and it causes spurrious test
failures
Copy link
Collaborator

@jbruggem jbruggem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jbruggem
Copy link
Collaborator

jbruggem commented Jan 7, 2021

@dantswain do you want to merge this ?

@dantswain
Copy link
Collaborator Author

Ah thanks for reminding me. I think I had sort of shelved this because I was investigating alternatives to travis-ci, but that stalled out, so might as well do this to help get rid of some spurious build failures.

@dantswain dantswain merged commit 301c483 into master Jan 7, 2021
@dantswain dantswain deleted the uncoveralled branch January 7, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants