Add Github actions CI #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerbal Thanks so much for taking this on! It would be a huge help if you could get this to work reliably! Generally what seems to happen with the integration tests is that because we need to run a 3-node kafka cluster AND the tests, any cpu-constrained environment will have all kinds of bad behavior because that resource is constrained. I think we want to have at least 2 nodes (3 is probably better) in our test cluster because otherwise we aren't going to exercise any of the tricky metadata juggling. |
|
Thanks @dantswain! I'll keep hacking on this as I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #421 and #422 - I took a whack at writing some github actions to run the test suite and added some additional checks.
I've split the integration tests apart to run in a matrix. I was hoping this would decrease the flakeyness in testing, but if anything it seems a bit worse. On the plus side, it's a bit faster to run all the tests in parallel tasks. Are there tweaks to the kafka configuration to let it run better in small vms?
I have also added common CI code quality checks. Currently this includes
credo,mix format --check-formatted,mix compile --warnings-as-errors --force, anddialyzer.