#1 encode null array elements

kagis · Mar 24, 2019 · 8375db4 · 8375db4
1 parent 09c9538
commit 8375db4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/datatypes.js b/lib/datatypes.js
@@ -160,7 +160,9 @@ function decodeBinArray(buf, decodeElem) {
 
 // FIXME: one dimension only
 function encodeTextArray(arr, encodeElem) {
-  return JSON.stringify(arr.map(encodeElem)).replace(/^\[(.*)]$/, '{$1}');
+  return JSON.stringify(arr, function (_, elem) {
+    return this == arr && elem != null ? encodeElem(elem) : elem;
+  }).replace(/^\[(.*)]$/, '{$1}');
 }
 
 // FIXME: one dimension only

diff --git a/test/test.js b/test/test.js
@@ -556,7 +556,7 @@ it('param explicit type', async () => {
         },
       }, {
         type: 'text[]',
-        value: ['1', '2', '3'],
+        value: ['1', '2', '3', null],
       }, {
         type: 'bytea[]',
         value: ['x', 'y', 'z'],
@@ -567,7 +567,7 @@ it('param explicit type', async () => {
     'integer', 1,
     'boolean', true,
     'jsonb', 'hello',
-    'text[]', '{1,2,3}',
+    'text[]', '{1,2,3,NULL}',
     'bytea[]', '{"\\\\x78","\\\\x79","\\\\x7a"}',
   ]);
 });