Skip to content

Commit

Permalink
feat: Remove Java 8 support (#456)
Browse files Browse the repository at this point in the history
Remove Java 8 support
  • Loading branch information
kagkarlsson authored Jan 13, 2024
1 parent 4d3b5bb commit bb17380
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ '8', '11', '17' ]
java: [ '11', '17', '21' ]
name: Temurin ${{ matrix.java }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .sdkmanrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
java=17.0.7-tem
java=21-librca
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void fails_when_one_required_delegate_fails() {
@Test
public void cannot_create_from_null_or_empty_list() {
assertUnableToCreateParser(null);
assertUnableToCreateParser();
assertUnableToCreateParser(new Parser[] {});
}

@Test
Expand All @@ -85,7 +85,7 @@ static void assertParsingResult(Schedule expected, Parser... parsers) {
assertEquals(Optional.of(expected), CompositeParser.of(parsers).parse(ANY_SCHEDULE_STRING));
}

static void assertUnableToCreateParser(Parser... parsers) {
static void assertUnableToCreateParser(Parser[] parsers) {
try {
CompositeParser.of(parsers);
fail("Should have thrown IllegalArgumentException");
Expand Down
9 changes: 8 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jdk.version>1.8</jdk.version>
<jdk.version>11</jdk.version>
<maven.compiler.source>${jdk.version}</maven.compiler.source>
<maven.compiler.target>${jdk.version}</maven.compiler.target>
<maven.compiler.release>${jdk.version}</maven.compiler.release>
<compilerArgument />
<license.dir>${project.basedir}/.license</license.dir>

Expand Down Expand Up @@ -180,6 +181,12 @@
<exclude>META-INF/**</exclude>
</excludes>
</filter>
<filter>
<artifact>com.github.kagkarlsson:micro-jdbc:*</artifact>
<excludes>
<exclude>META-INF/**</exclude>
</excludes>
</filter>
</filters>
<relocations>
<relocation>
Expand Down

0 comments on commit bb17380

Please sign in to comment.